Open
Conversation
The given answer failed to account for qty values above 20. In the case of the "banana" item, it returned an freeQty value of 6. In the exercise description it states "Purchases of 5 or more receive 1 free. Purchases of 10 or more receive 3 free". The original code added +3 for each 10 instead of +3 if qty is >= 10. Great course otherwise :) .
|
In your diff, you should retain a generic |
|
Like this, right? free minQty freeQty item =
if item.freeQty == 0 && item.qty >= minQty then
{ item | freeQty = freeQty }
else
itemI just noticed this issue, and came here to make a PR for the same reason :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The given answer failed to account for qty values above 20. In the case of the "banana" item, it returned an freeQty value of 6. In the exercise description it states "Purchases of 5 or more receive 1 free. Purchases of 10 or more receive 3 free". The original code added +3 for each 10 instead of +3 if qty is >= 10. Great course otherwise :) .