Skip to content
This repository was archived by the owner on Feb 12, 2026. It is now read-only.
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions ratethisapp/src/main/java/com/kobakei/ratethisapp/RateThisApp.java
Original file line number Diff line number Diff line change
@@ -1,20 +1,3 @@
/*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep license comment

* Copyright 2013-2017 Keisuke Kobayashi
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.kobakei.ratethisapp;

import java.lang.ref.WeakReference;
import java.util.Date;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -62,6 +45,9 @@ public class RateThisApp {
// Weak ref to avoid leaking the context
private static WeakReference<AlertDialog> sDialogRef = null;

private static AlertDialog dialog;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @Nullable to dialog and builder

private static AlertDialog.Builder builder;

/**
* If true, print LogCat
*/
Expand Down Expand Up @@ -166,7 +152,7 @@ public static boolean shouldShowRateDialog() {
}
long threshold = TimeUnit.DAYS.toMillis(sConfig.mCriteriaInstallDays); // msec
if (new Date().getTime() - mInstallDate.getTime() >= threshold &&
new Date().getTime() - mAskLaterDate.getTime() >= threshold) {
new Date().getTime() - mAskLaterDate.getTime() >= threshold) {
return true;
}
return false;
Expand All @@ -178,7 +164,8 @@ public static boolean shouldShowRateDialog() {
* @param context
*/
public static void showRateDialog(final Context context) {
AlertDialog.Builder builder = new AlertDialog.Builder(context);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about builder and dialog are not null? (= dialog is shown)
It may be better to do nothing on the situation.

builder = new AlertDialog.Builder(context);
dialog = builder.create();
showRateDialog(context, builder);
}

Expand All @@ -188,10 +175,19 @@ public static void showRateDialog(final Context context) {
* @param themeId
*/
public static void showRateDialog(final Context context, int themeId) {
AlertDialog.Builder builder = new AlertDialog.Builder(context, themeId);
builder = new AlertDialog.Builder(context, themeId);
dialog = builder.create();
showRateDialog(context, builder);
}

/**
* Dismiss the rate dialog
*/
public static void dismissRateDialog() {
if (dialog != null)
dialog.dismiss();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add dialog = null;

}

/**
* Stop showing the rate dialog
* @param context
Expand Down Expand Up @@ -298,7 +294,10 @@ public void onDismiss(DialogInterface dialog) {
sDialogRef.clear();
}
});
sDialogRef = new WeakReference<>(builder.show());

dialog = builder.create();
sDialogRef = new WeakReference<>(dialog);
dialog.show();
}

/**
Expand Down Expand Up @@ -468,9 +467,9 @@ public void setUrl(String url) {
}

/**
* Set the cancel mode; namely, which ways the user can cancel the dialog.
* @param cancelMode
*/
* Set the cancel mode; namely, which ways the user can cancel the dialog.
* @param cancelMode
*/
public void setCancelMode(int cancelMode) {
this.mCancelMode = cancelMode;
}
Expand Down