This repository was archived by the owner on Feb 12, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 164
Added dismissRateDialog() function. #92
Open
Zeykit
wants to merge
2
commits into
kobakei:master
Choose a base branch
from
Zeykit:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,3 @@ | ||
| /* | ||
| * Copyright 2013-2017 Keisuke Kobayashi | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.kobakei.ratethisapp; | ||
|
|
||
| import java.lang.ref.WeakReference; | ||
| import java.util.Date; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
@@ -62,6 +45,9 @@ public class RateThisApp { | |
| // Weak ref to avoid leaking the context | ||
| private static WeakReference<AlertDialog> sDialogRef = null; | ||
|
|
||
| private static AlertDialog dialog; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add |
||
| private static AlertDialog.Builder builder; | ||
|
|
||
| /** | ||
| * If true, print LogCat | ||
| */ | ||
|
|
@@ -166,7 +152,7 @@ public static boolean shouldShowRateDialog() { | |
| } | ||
| long threshold = TimeUnit.DAYS.toMillis(sConfig.mCriteriaInstallDays); // msec | ||
| if (new Date().getTime() - mInstallDate.getTime() >= threshold && | ||
| new Date().getTime() - mAskLaterDate.getTime() >= threshold) { | ||
| new Date().getTime() - mAskLaterDate.getTime() >= threshold) { | ||
| return true; | ||
| } | ||
| return false; | ||
|
|
@@ -178,7 +164,8 @@ public static boolean shouldShowRateDialog() { | |
| * @param context | ||
| */ | ||
| public static void showRateDialog(final Context context) { | ||
| AlertDialog.Builder builder = new AlertDialog.Builder(context); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about |
||
| builder = new AlertDialog.Builder(context); | ||
| dialog = builder.create(); | ||
| showRateDialog(context, builder); | ||
| } | ||
|
|
||
|
|
@@ -188,10 +175,19 @@ public static void showRateDialog(final Context context) { | |
| * @param themeId | ||
| */ | ||
| public static void showRateDialog(final Context context, int themeId) { | ||
| AlertDialog.Builder builder = new AlertDialog.Builder(context, themeId); | ||
| builder = new AlertDialog.Builder(context, themeId); | ||
| dialog = builder.create(); | ||
| showRateDialog(context, builder); | ||
| } | ||
|
|
||
| /** | ||
| * Dismiss the rate dialog | ||
| */ | ||
| public static void dismissRateDialog() { | ||
| if (dialog != null) | ||
| dialog.dismiss(); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add |
||
| } | ||
|
|
||
| /** | ||
| * Stop showing the rate dialog | ||
| * @param context | ||
|
|
@@ -298,7 +294,10 @@ public void onDismiss(DialogInterface dialog) { | |
| sDialogRef.clear(); | ||
| } | ||
| }); | ||
| sDialogRef = new WeakReference<>(builder.show()); | ||
|
|
||
| dialog = builder.create(); | ||
| sDialogRef = new WeakReference<>(dialog); | ||
| dialog.show(); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -468,9 +467,9 @@ public void setUrl(String url) { | |
| } | ||
|
|
||
| /** | ||
| * Set the cancel mode; namely, which ways the user can cancel the dialog. | ||
| * @param cancelMode | ||
| */ | ||
| * Set the cancel mode; namely, which ways the user can cancel the dialog. | ||
| * @param cancelMode | ||
| */ | ||
| public void setCancelMode(int cancelMode) { | ||
| this.mCancelMode = cancelMode; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep license comment