Skip to content

fix: avoid reflective listener scans for dependency metrics #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DerMistkaefer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: avoid reflective listener scans for dependency metrics #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 12 additions & 23 deletions src/main/java/com/xxmicloxx/NoteBlockAPI/NoteBlockAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
import org.bukkit.scheduler.BukkitWorker;

import java.io.IOException;
import java.lang.reflect.Method;
import java.lang.reflect.Type;
import java.util.*;
import java.util.concurrent.ConcurrentHashMap;

Expand Down Expand Up @@ -151,27 +149,18 @@ public void onEnable() {

@Override
public void run() {
Plugin[] plugins = getServer().getPluginManager().getPlugins();
Type[] types = new Type[]{PlayerRangeStateChangeEvent.class, SongDestroyingEvent.class, SongEndEvent.class, SongStoppedEvent.class };
for (Plugin plugin : plugins) {
ArrayList<RegisteredListener> rls = HandlerList.getRegisteredListeners(plugin);
for (RegisteredListener rl : rls) {
Method[] methods = rl.getListener().getClass().getDeclaredMethods();
for (Method m : methods) {
Type[] params = m.getParameterTypes();
param:
for (Type paramType : params) {
for (Type type : types){
if (paramType.equals(type)) {
dependentPlugins.put(plugin, true);
break param;
}
}
}
}

}
}
for (RegisteredListener rl : PlayerRangeStateChangeEvent.getHandlerList().getRegisteredListeners()) {
dependentPlugins.put(rl.getPlugin(), true);
}
for (RegisteredListener rl : SongDestroyingEvent.getHandlerList().getRegisteredListeners()) {
dependentPlugins.put(rl.getPlugin(), true);
}
for (RegisteredListener rl : SongEndEvent.getHandlerList().getRegisteredListeners()) {
dependentPlugins.put(rl.getPlugin(), true);
}
for (RegisteredListener rl : SongStoppedEvent.getHandlerList().getRegisteredListeners()) {
dependentPlugins.put(rl.getPlugin(), true);
}

metrics.addCustomChart(new DrilldownPie("deprecated", () -> {
Map<String, Map<String, Integer>> map = new HashMap<>();
Expand Down