fix: insert line break before error messages for better readability#5
fix: insert line break before error messages for better readability#5asimtahir-karakus-kd wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves error message readability by inserting line breaks before error messages in the streempublic.js file. The changes ensure that error messages appear on a new line, which is particularly important after progress bar output.
- Adds newline output before error messages in the getFile error handler
- Wraps the getFile call in a try-catch block with consistent error formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } catch (err) { | ||
| process.stdout.write('\n'); | ||
| error('Error downloading MainFrame Xpublic zip file:'); | ||
| error(err); |
There was a problem hiding this comment.
The try-catch block catches errors but doesn't prevent the function from continuing execution. After an error occurs during file download, the code proceeds to lines 78-82 where it attempts to unzip a file that may not exist (localzipfile), which will cause additional errors. The catch block should either re-throw the error or return early to prevent further execution.
| error(err); | |
| error(err); | |
| throw err; |
Fixes: #4