Skip to content

[WIP]fix: preserve soft-delete flags in workflow task ACK writes. #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leozhang2018 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP]fix: preserve soft-delete flags in workflow task ACK writes. #4620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/microservice/aslan/core/common/service/workflowcontroller/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,15 @@ func (c *workflowCtl) updateWorkflowTask() {

c.workflowTask.Remark = ""

// Preserve the soft-delete flags from the DB copy. The in-memory task was
// loaded before the workflow could have been deleted, so its IsDeleted /
// IsArchived fields may be stale (false). Blindly writing them back via
// $set would silently undo a soft-delete performed by DeleteWorkflowV4,
// making the task reappear in the UI as "running" even after the workflow
// has been removed.
c.workflowTask.IsDeleted = taskInColl.IsDeleted
c.workflowTask.IsArchived = taskInColl.IsArchived

c.workflowTaskMutex.Lock()
if err := commonrepo.NewworkflowTaskv4Coll().Update(c.workflowTask.ID.Hex(), c.workflowTask); err != nil {
c.workflowTaskMutex.Unlock()
Expand Down
Loading