Skip to content

feat: include release plan in workflow webhook payload#4686

Open
huanghongbo-hhb wants to merge 2 commits into
koderover:mainfrom
huanghongbo-hhb:feat/workflow-webhook-release-plan-v1
Open

feat: include release plan in workflow webhook payload#4686
huanghongbo-hhb wants to merge 2 commits into
koderover:mainfrom
huanghongbo-hhb:feat/workflow-webhook-release-plan-v1

Conversation

@huanghongbo-hhb
Copy link
Copy Markdown
Contributor

@huanghongbo-hhb huanghongbo-hhb commented May 19, 2026

Summary

  • add release_plan to workflow webhook payloads when a workflow task is triggered by a release plan
  • keep the field optional so existing webhook consumers remain compatible
  • reuse the existing release plan task metadata without changing webhook event types

Testing

  • go test -run TestDoesNotExist ./pkg/microservice/aslan/core/common/service/webhooknotify
  • go test -run TestDoesNotExist ./pkg/microservice/aslan/core/common/service/instantmessage (timed out locally under resource pressure after code changes)
  • verified with a real workflow webhook receiver (webhook.site) after deploying the PR build
  • manual trigger case: payload stayed object_kind=workflow, top-level release_plan=null, and workflow.release_plan was absent
  • release plan trigger case: payload stayed object_kind=workflow, top-level release_plan=null, and workflow.release_plan={id,name,index} was present as expected

Conclusion

  • external webhook consumers can now read release plan metadata from workflow.release_plan when the workflow task is triggered by a release plan
  • manually triggered workflow tasks remain unchanged and do not include workflow.release_plan

Contact


This change is Reviewable

Signed-off-by: huanghongbo <huanghongbo@koderover.com>
Comment thread pkg/microservice/aslan/core/common/service/webhooknotify/types.go Outdated
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants