Skip to content

feat: add system workflow webhook events#4710

Open
huanghongbo-hhb wants to merge 4 commits into
koderover:mainfrom
huanghongbo-hhb:feat/system-webhook-workflow-events-main
Open

feat: add system workflow webhook events#4710
huanghongbo-hhb wants to merge 4 commits into
koderover:mainfrom
huanghongbo-hhb:feat/system-webhook-workflow-events-main

Conversation

@huanghongbo-hhb
Copy link
Copy Markdown
Contributor

@huanghongbo-hhb huanghongbo-hhb commented May 22, 2026

Summary

  • Add system-level workflow webhook settings for workflow start and completion events

Why

  • Support a global workflow webhook entry in system settings without introducing callback behavior
  • Reuse the existing workflow notification webhook payload so external integrations receive consistent task data

Main Changes

  • Add workflow_hook system settings with enable, hook_address, hook_secret, and hook_events
  • Add system APIs to get and update workflow webhook settings
  • Trigger system workflow webhooks on workflow start and workflow completion
  • Reuse the existing workflow notification payload and include workflow.event_name to distinguish start_execute and complete_execute
  • Add a unit test for workflow hook event filtering

Risk / Compatibility

  • Low risk because this is additive and gated by a new system setting
  • Existing workflow notification hooks are unchanged
  • The new webhook path reuses the current workflow payload shape, with only an additional event_name field for the system workflow hook scenario

Test

  • go test -vet=off ./pkg/microservice/aslan/core/common/service/instantmessage
  • go test -vet=off ./pkg/microservice/aslan/core/common/service/instantmessage ./pkg/microservice/aslan/core/common/service/workflowcontroller ./pkg/microservice/aslan/core/system/handler ./pkg/microservice/aslan/core/system/service ./pkg/microservice/aslan/core/workflow/service/workflow

Contact


This change is Reviewable

Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant