Bind /prep-compact to the invoking session (+ handoff noise filter, single-line /compact)#5
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0721c0baf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _nrm() { if command -v cygpath >/dev/null 2>&1; then cygpath -m "$1" 2>/dev/null || printf '%s' "$1"; else printf '%s' "$1"; fi; } | ||
| PLUGIN_DATA_N=""; [ -n "${CLAUDE_PLUGIN_DATA:-}" ] && PLUGIN_DATA_N="$(_nrm "$CLAUDE_PLUGIN_DATA")" | ||
|
|
||
| SID="${CLAUDE_CODE_SESSION_ID:-}" \ |
There was a problem hiding this comment.
When /prep-compact runs this helper from the skill, there is no hook JSON on stdin and Claude Code does not export the hook session_id as CLAUDE_CODE_SESSION_ID; the session id is only provided in hook input. In that normal invocation path SID is empty, the resolver prints NOSID, and the skill always falls back to the in-memory survey instead of reading the warm handoff the Stop hook just wrote, effectively disabling the core cumulative handoff behavior for users unless they happened to set this nonstandard env var themselves.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is wrong, CLAUDE_CODE_SESSION_ID is exposed, it just is not documented (yet)
|
|
||
| _NOISE_RE = re.compile( | ||
| r'(?:^|[\\/])\.git[\\/]' # .git/ internals | ||
| r'|^/tmp/' # POSIX root temp |
There was a problem hiding this comment.
When the repository itself is checked out under /tmp (common in CI, disposable sandboxes, or repro directories), every absolute path captured from normal Read/Edit/Write calls starts with /tmp/, so this filter removes the actual project files from both recent_files and cumulative_files. In that context /prep-compact loses the file list it is supposed to preserve, not just transient scratch files.
Useful? React with 👍 / 👎.
|
/tmp/ exclusion is dumb and way too aggressive and broad, it creates a real risk of excluding working files. Reverting this so only .git and the plugin's own cache files are excluded |
Temp dirs (/tmp, C:\tmp, AppData\Local\Temp) hold real user files; blacklisting them risked dropping work from the handoff. Keep only .git/ and .claude/plugins/{data,cache}/.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
What and why
When several Claude Code sessions run in the same project,
/prep-compactcould read the wrong session's handoff. The old §1 discovery globbedhandoff-*.json, filtered by cwd, and picked the newestmtime, so in a shared working directory it would select a sibling session's record and contaminate the extractive fields (files,recent_user_requests,in_progress,agents). This binds the lookup to the invoking session instead, trims non-user noise out of the handoff, and makes the drafted/compactreliably one line.Changes
skills/prep-compact/resolve-handoff.shresolves the invoking session's own handoff by$CLAUDE_CODE_SESSION_ID(sanitised the same way as the hooks), validates the storedcwd, and printsHIT\n<path>/MISS/NOSID. Fail-open (always exit 0), deterministic root priority, malformed-candidate skip, andC:\..vs/c/..canonicalisation for Git Bash..git/internals and.claude/plugins/{data,cache}/paths (VCS/plugin plumbing) fromrecent_files/cumulative_files, and drops injected messages (<task-notification>,[SYSTEM NOTIFICATION, skill-load preambles) fromrecent_user_requests. Real source files, temp dirs, and~/.claudeconfig reads are kept: the handoff is an inclusion list, so it should over-include rather than risk dropping real work./compact. Removed the multi-line escape hatch from §4 and added a pre-emit verify gate in §5, so a stray newline after/compactcan't drop the instructions.Testing
bash test/run-tests.sh: 127 assertions, green on Windows Git Bash. New coverage: handoff noise filter (T-52..T-55), resolver unit tests (T-42..T-50, including the sibling-not-selected and cwd-mismatch regressions), §1 binding (T-41), single-line gate (T-51).Possible follow-up (not in this PR)
session_id. For real UUID sessions the filename equals the stored id, so this is belt-and-suspenders only; worth adding if we ever want to defend against a hand-misnamed file.🤖 Generated with Claude Code