Check type assertion success for pubkeys to avoid panic#55
Merged
RebeccaMahany merged 1 commit intokolide:mainfrom Jul 8, 2025
Merged
Check type assertion success for pubkeys to avoid panic#55RebeccaMahany merged 1 commit intokolide:mainfrom
RebeccaMahany merged 1 commit intokolide:mainfrom
Conversation
zackattack01
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We generally expect to be working with ECDSA pubkeys. We sometimes perform type assertions to convert the
SignerPubKeyinterface into an ECDSA pubkey, which can panic if given a different type of pubkey. This PR updates to ensure we check the type assertion was successful, to avoid the panic.