Add testthat coverage and finalize docs for empirical RIR#126
Open
JihoonChoi26 wants to merge 15 commits into
Open
Add testthat coverage and finalize docs for empirical RIR#126JihoonChoi26 wants to merge 15 commits into
JihoonChoi26 wants to merge 15 commits into
Conversation
tests/testthat/test-corr-rir.R 5 tests covering test_correlation_rir(): canonical t-scale numeric crosscheck, non-significant sustain branch, r-scale vs t-scale divergence, GLM gate (scale="t" blocked), and GLM smoke test. tests/testthat/test-empirical-rir.R 9 tests covering the empirical RIR pipeline: refit_like() coefficient identity, prep_empirical_rir() vector dimensions and error on missing model frame, label_cases() ci_share normalization and factor structure, find_k_star() bounded output, and konfound_empdist() class contract, seed reproducibility, and non-significant error guard.
Collaborator
Author
|
Hi Josh! a few more updates are coming to this PR based on recent discussion with Dr. Frank, mainly around the RIR printed output. Will push those shortly and ping you when it's ready for a review. Thanks! |
Mege from master branch
- New exported function robust_attrition() (beta) in R/robust_attrition.R - Argument names aligned with pkonfound family (std_err, n_covariates) - Tests in tests/testthat/test-robust-attrition.R - Additional update in test_corr_RIR.R output dispatch
Add robust_attrition in it
update input validation part
VAM print output update with linebreak, citation added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes. The first two address Josh's feedback on missing test
coverage and doc quality. The third is a new master-only function, not
part of the CRAN release.
Tests:
Docs:
removed, full @description and \donttest{} example added
Master-only (not for CRAN):
Standalone export in R/test_attrition.R, held back from the public release.
All tests pass (0 errors, 0 warnings on devtools::check()).