[AUTOMATION] fix: optimize auth login scope deduplication#285
Open
michiosw wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR optimizes login scope deduplication in the OIDC auth flow. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Reviews (1): Last reviewed commit: "fix: optimize auth login scope deduplica..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This optimizes auth login scope resolution by replacing repeated duplicate scans with one stable dedupe pass.
Before this,
resolveLoginScopesininternal/auth/oidc.gochecked every requested scope against the growing result slice, which repeated linear scans as the input list grew.Now a single
seenset is the canonical path:Why
This gives kontext-cli a cheaper runtime path for login scope selection:
login scope input
->
resolveLoginScopes-> deduped ordered scope list
This PR does not broaden behavior beyond the optimization scope.
What changed
Optimized auth login scope deduplication
Removed repeated linear scope membership scans
Preserved scope order and default scope behavior
Updated tests for repeated custom scope inputs
Verification
go test ./internal/auth
go test ./internal/auth -run 'TestResolveLoginScopes'
go test ./internal/guard/judge -run TestStartLlamaServerEarlyExitDoesNotWaitForStopTimeout -count=3
go test ./...
go vet ./...
git diff --check