fix(selfserve): harden managed observe cli readiness#286
Open
michiosw wants to merge 1 commit into
Open
Conversation
This was referenced Jun 13, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Greptile SummaryThis PR hardens managed observe diagnostics and stream cursor persistence. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(selfserve): harden managed observe c..." | Re-trigger Greptile |
912e0bd to
ab1ffbb
Compare
19450d0 to
79d8be0
Compare
ab1ffbb to
7a6ba53
Compare
79d8be0 to
52a1ded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Where We Are
The managed observe CLI stack is ready, but review found error-handling gaps around corrupt installation state, auth breadcrumb cleanup, and stream cursor typing.
Where We Want To Go
Keep the existing CLI stack PRs focused and add one cleanup PR that makes runtime diagnostics and persisted state safer before review.
How do we get there
This branch reports corrupt installation state as an error, returns and logs auth breadcrumb delete failures, preserves managed stream cursor JSON compatibility with stricter in-memory typing, and removes dead wrappers. Verified with go build ./..., go vet ./..., go test ./..., go test -race ./..., govulncheck ./..., codex-review, and autoreview.