Skip to content

fix(selfserve): harden managed observe cli readiness#286

Open
michiosw wants to merge 1 commit into
selfserve-auth-devxfrom
feat/selfserve-cli-production-readiness
Open

fix(selfserve): harden managed observe cli readiness#286
michiosw wants to merge 1 commit into
selfserve-auth-devxfrom
feat/selfserve-cli-production-readiness

Conversation

@michiosw

Copy link
Copy Markdown
Contributor

Where We Are

The managed observe CLI stack is ready, but review found error-handling gaps around corrupt installation state, auth breadcrumb cleanup, and stream cursor typing.

Where We Want To Go

Keep the existing CLI stack PRs focused and add one cleanup PR that makes runtime diagnostics and persisted state safer before review.

How do we get there

This branch reports corrupt installation state as an error, returns and logs auth breadcrumb delete failures, preserves managed stream cursor JSON compatibility with stricter in-memory typing, and removes dead wrappers. Verified with go build ./..., go vet ./..., go test ./..., go test -race ./..., govulncheck ./..., codex-review, and autoreview.

michiosw commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps

greptile-apps Bot commented Jun 13, 2026

Copy link
Copy Markdown

Greptile Summary

This PR hardens managed observe diagnostics and stream cursor persistence. The main changes are:

  • Reports corrupt installation state separately from missing state.
  • Returns and logs auth breadcrumb cleanup failures.
  • Keeps managed stream cursor JSON compatible while using typed timestamps in memory.
  • Removes unused managed config and installation helper wrappers.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
internal/managedstream/stream.go Moves cursor parsing into state loading while preserving the existing persisted JSON shape.
internal/managedobserve/autherr.go Makes breadcrumb deletion errors observable while keeping missing breadcrumbs as a no-op.
internal/managedobserve/doctor.go Distinguishes missing installation identity from invalid or unreadable installation state.

Reviews (1): Last reviewed commit: "fix(selfserve): harden managed observe c..." | Re-trigger Greptile

@michiosw michiosw force-pushed the selfserve-auth-devx branch from 912e0bd to ab1ffbb Compare June 13, 2026 09:34
@michiosw michiosw force-pushed the feat/selfserve-cli-production-readiness branch from 19450d0 to 79d8be0 Compare June 13, 2026 09:34
@michiosw michiosw requested a review from hasandemirkiran June 13, 2026 11:20
@michiosw michiosw force-pushed the selfserve-auth-devx branch from ab1ffbb to 7a6ba53 Compare June 13, 2026 11:30
@michiosw michiosw force-pushed the feat/selfserve-cli-production-readiness branch from 79d8be0 to 52a1ded Compare June 13, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant