-
Notifications
You must be signed in to change notification settings - Fork 4
docs(time-range): update article text and preset labels (#DS-4918) #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0bd1833
docs(time-range): update article text per copy review (#DS-4918)
rmnturov a8fa253
fix(time-range): capitalize preset labels and localize overview examp…
rmnturov 565ba90
docs(time-range): drop preposition in empty-type-list example trigger…
rmnturov 9d3c3d8
docs(time-range): tweak min-max example placeholder and trigger label…
rmnturov aa2423a
docs(time-range): localize custom-range-types example labels (#DS-4918)
rmnturov b59e3ff
chore(core): regenerate api report for time-range EN locale fields (#…
rmnturov 52ecadc
docs(time-range): move All time preset to the end in overview example…
rmnturov 9fbc8c5
fix(time-range): keep custom period selection after reopening popover…
rmnturov 46c5eb9
fix(time-range): fill preset option labels in es-LA, pt-BR and tk-TM …
rmnturov f04e50a
chore(core): regenerate api report for remaining time-range locale fi…
rmnturov 3abf02e
fix(time-range): use correct russian plural form for years in duratio…
rmnturov f2268ee
docs(time-range): align min-max example date limits with article text…
rmnturov 26ae526
docs(time-range): fix years translation type and guard empty range va…
rmnturov 6b00356
docs(time-range): localize period placeholder in as-form-field and cu…
rmnturov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,27 @@ | ||
| Time range selection menu. The user can choose one of the preset values or specify the range manually. | ||
| Time range selection menu. The user can choose one of the preset values or specify the time range manually. | ||
|
|
||
| <!-- example(time-range-overview) --> | ||
|
|
||
| ### Trigger element | ||
|
|
||
| The menu can drop down from different trigger elements, and the window can have a pointer. | ||
| The component allows you to customize the trigger element. For example, it can be a button, a field, or a pseudo-link. | ||
|
|
||
| <!-- example(time-range-custom-trigger) --> | ||
|
|
||
| ### Custom presets | ||
|
|
||
| When there are no preset values, only the From and To fields remain in the dialog: | ||
| When there are no preset values, only the start and end of the period remain in the window. | ||
|
|
||
| <!-- example(time-range-empty-type-list) --> | ||
|
|
||
| ### Selection restriction | ||
|
|
||
| It is possible to configure the minimum and maximum date: | ||
| You can configure the minimum and maximum date. For example, a range from 2015 to 2017. | ||
|
NikGurev marked this conversation as resolved.
|
||
|
|
||
| <!-- example(time-range-min-max) --> | ||
|
|
||
| ### Custom time ranges | ||
|
|
||
| The option to configure interval selection is available: | ||
| The component allows you to set custom time range options. | ||
|
|
||
| <!-- example(time-range-custom-range-types) --> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.