fix(filter-bar): render pipe-select options on first open when templates arrive late (#DS-5263)#1718
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
скриншот тесты изменились, так и должно быть? |
перепроверил, да, из-за фикса теперь другое поведение и нужно обновлять скриншоты |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
There was a problem hiding this comment.
Pull request overview
Fixes a filter-bar Select pipe edge case where option values don’t render on the first open if pipeTemplates (and therefore values) are assigned after the pipe component has already been created (e.g. parent sets templates in ngAfterViewInit).
Changes:
- Updated
KbqPipeSelectComponentto recomputefilteredOptionswheneverKbqFilterBar.internalTemplatesChangesemits, not only on search input changes. - Refactored filtering to always use the current
searchControl.value, ensuring template-change re-emissions apply the active search term. - Added a unit test covering the “late
pipeTemplates” first-open rendering scenario.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/filter-bar/pipes/pipe-select.ts | Recomputes select options when templates change after init by merging internalTemplatesChanges into the filteredOptions stream. |
| packages/components/filter-bar/pipes/pipe-select.spec.ts | Adds regression test ensuring options render on first open when templates arrive late. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tes arrive late (#DS-5263)
|
Visit the preview URL for this PR (updated for commit 671c4db): https://koobiq-next--prs-1718-nj607hz0.web.app (expires Mon, 13 Jul 2026 12:36:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
No description provided.