Skip to content

fix(filter-bar): render pipe-select options on first open when templates arrive late (#DS-5263)#1718

Merged
lskramarov merged 2 commits into
mainfrom
fix/DS-5263
Jul 10, 2026
Merged

fix(filter-bar): render pipe-select options on first open when templates arrive late (#DS-5263)#1718
lskramarov merged 2 commits into
mainfrom
fix/DS-5263

Conversation

@lskramarov

Copy link
Copy Markdown
Contributor

No description provided.

@lskramarov lskramarov requested review from NikGurev and artembelik July 9, 2026 11:43
@lskramarov lskramarov self-assigned this Jul 9, 2026
@lskramarov lskramarov added the bug Something isn't working label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev

NikGurev commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

скриншот тесты изменились, так и должно быть?

@lskramarov

Copy link
Copy Markdown
Contributor Author

скриншот тесты изменились, так и должно быть?

перепроверил, да, из-за фикса теперь другое поведение и нужно обновлять скриншоты

@lskramarov

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

✅ Snapshots updated!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a filter-bar Select pipe edge case where option values don’t render on the first open if pipeTemplates (and therefore values) are assigned after the pipe component has already been created (e.g. parent sets templates in ngAfterViewInit).

Changes:

  • Updated KbqPipeSelectComponent to recompute filteredOptions whenever KbqFilterBar.internalTemplatesChanges emits, not only on search input changes.
  • Refactored filtering to always use the current searchControl.value, ensuring template-change re-emissions apply the active search term.
  • Added a unit test covering the “late pipeTemplates” first-open rendering scenario.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
packages/components/filter-bar/pipes/pipe-select.ts Recomputes select options when templates change after init by merging internalTemplatesChanges into the filteredOptions stream.
packages/components/filter-bar/pipes/pipe-select.spec.ts Adds regression test ensuring options render on first open when templates arrive late.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from fix/DS-5302 to main July 10, 2026 12:20
@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 671c4db):

https://koobiq-next--prs-1718-nj607hz0.web.app

(expires Mon, 13 Jul 2026 12:36:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@lskramarov lskramarov merged commit 0741cc4 into main Jul 10, 2026
11 checks passed
@lskramarov lskramarov deleted the fix/DS-5263 branch July 10, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants