Skip to content

chore: setup docker for playwright tests (#DS-5167)#178

Merged
artembelik merged 9 commits into
mainfrom
chore/DS-5167
Jul 2, 2026
Merged

chore: setup docker for playwright tests (#DS-5167)#178
artembelik merged 9 commits into
mainfrom
chore/DS-5167

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

No description provided.

@artembelik artembelik self-assigned this Jun 30, 2026
Copilot AI review requested due to automatic review settings June 30, 2026 13:11
@github-actions

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit d0b1868):

https://data-grid-next--data-grid-pr-178-sgziuhfw.web.app

(expires Tue, 07 Jul 2026 07:49:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b9d49913f5b5988e9af8690a8b37f16143707448

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a Docker-based workflow for running Playwright E2E tests (to better match CI and reduce OS-dependent snapshot diffs), updates CI workflows to use the Docker path, and adjusts formatting/tooling and a couple of E2E test waits/timeouts.

Changes:

  • Add tools/e2e Dockerfile + docker-compose setup and expose it via e2e:docker scripts.
  • Switch GitHub Actions E2E workflows to run tests via Docker and update snapshot approval to include *.txt artifacts.
  • Update Prettier tooling (Prettier + prettier-plugin-sh) and tweak some Playwright test waits/timeouts.

Reviewed changes

Copilot reviewed 10 out of 20 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
yarn.lock Adds lock entries for prettier-plugin-sh dependencies and updates Prettier version resolution.
tools/e2e/Dockerfile New Playwright-based image to run E2E tests inside Docker.
tools/e2e/docker-compose.yml New compose service to build/run the E2E container and mount reports/snapshots back to host.
tools/e2e/.dockerignore New ignore rules intended to minimize build context contents.
package.json Adds e2e:docker scripts and bumps Prettier / adds prettier-plugin-sh.
dev/ag-grid-angular/src/tests/row-actions.playwright-spec.ts Tweaks hover timing to reduce long waits on failure.
dev/ag-grid-angular/src/tests/infinite-selection.playwright-spec.ts Refines waits around async state selection and changes several timeouts/assertions.
AGENTS.md Documents Docker-based snapshot updating and normalizes command examples to yarn run.
.prettierrc.js Enables prettier-plugin-sh.
.github/workflows/e2e.yml Runs E2E tests via Docker.
.github/workflows/e2e-approve-snapshots.yml Updates snapshots via Docker and commits both *.png and *.txt.

Comment thread tools/e2e/.dockerignore
Comment thread tools/e2e/Dockerfile
Comment thread tools/e2e/Dockerfile
Comment thread .github/workflows/e2e.yml Outdated
Comment thread .github/workflows/e2e-approve-snapshots.yml
Comment thread dev/ag-grid-angular/src/tests/infinite-selection.playwright-spec.ts Outdated
@github-actions

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@artembelik artembelik marked this pull request as draft July 1, 2026 14:34
@artembelik artembelik marked this pull request as ready for review July 2, 2026 08:01
@artembelik artembelik requested a review from Copilot July 2, 2026 08:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 37 changed files in this pull request and generated 3 comments.

Comment thread tools/e2e/.dockerignore
Comment thread tools/e2e/docker-compose.yml
Comment thread tools/e2e/docker-compose.yml
@artembelik artembelik merged commit 833f245 into main Jul 2, 2026
8 checks passed
@artembelik artembelik deleted the chore/DS-5167 branch July 2, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants