chore: setup docker for playwright tests (#DS-5167)#178
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
Visit the preview URL for this PR (updated for commit d0b1868): https://data-grid-next--data-grid-pr-178-sgziuhfw.web.app (expires Tue, 07 Jul 2026 07:49:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
There was a problem hiding this comment.
Pull request overview
This PR introduces a Docker-based workflow for running Playwright E2E tests (to better match CI and reduce OS-dependent snapshot diffs), updates CI workflows to use the Docker path, and adjusts formatting/tooling and a couple of E2E test waits/timeouts.
Changes:
- Add
tools/e2eDockerfile + docker-compose setup and expose it viae2e:dockerscripts. - Switch GitHub Actions E2E workflows to run tests via Docker and update snapshot approval to include
*.txtartifacts. - Update Prettier tooling (Prettier +
prettier-plugin-sh) and tweak some Playwright test waits/timeouts.
Reviewed changes
Copilot reviewed 10 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds lock entries for prettier-plugin-sh dependencies and updates Prettier version resolution. |
| tools/e2e/Dockerfile | New Playwright-based image to run E2E tests inside Docker. |
| tools/e2e/docker-compose.yml | New compose service to build/run the E2E container and mount reports/snapshots back to host. |
| tools/e2e/.dockerignore | New ignore rules intended to minimize build context contents. |
| package.json | Adds e2e:docker scripts and bumps Prettier / adds prettier-plugin-sh. |
| dev/ag-grid-angular/src/tests/row-actions.playwright-spec.ts | Tweaks hover timing to reduce long waits on failure. |
| dev/ag-grid-angular/src/tests/infinite-selection.playwright-spec.ts | Refines waits around async state selection and changes several timeouts/assertions. |
| AGENTS.md | Documents Docker-based snapshot updating and normalizes command examples to yarn run. |
| .prettierrc.js | Enables prettier-plugin-sh. |
| .github/workflows/e2e.yml | Runs E2E tests via Docker. |
| .github/workflows/e2e-approve-snapshots.yml | Updates snapshots via Docker and commits both *.png and *.txt. |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
No description provided.