chore: added eslint-plugin-playwright#185
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit b4fe550): https://data-grid-next--data-grid-pr-185-5cg8ijvw.web.app (expires Tue, 07 Jul 2026 09:11:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces eslint-plugin-playwright to enforce Playwright testing best practices across the repo’s E2E test suite, and updates existing Playwright specs to comply with the newly enabled rules.
Changes:
- Add
eslint-plugin-playwrightdependency (and lockfile entries). - Configure ESLint to apply
plugin:playwright/recommendedrules to Playwright spec files. - Update Playwright tests to satisfy Playwright ESLint recommendations (e.g., prefer
locator()usage andtoBeHidden()), plus add targeted rule disables for intentionalwaitForTimeout()usage.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds eslint-plugin-playwright to devDependencies. |
yarn.lock |
Locks eslint-plugin-playwright and its dependency (globals). |
.eslintrc.js |
Adds a Playwright-specific ESLint override extending plugin:playwright/recommended. |
.eslintignore |
Ignores .angular and playwright-report directories. |
dev/ag-grid-angular/src/tests/theme.playwright-spec.ts |
Updates interactions to use page.locator(...).hover()/click() patterns. |
dev/ag-grid-angular/src/tests/quick-filter-state.playwright-spec.ts |
Replaces not.toBeVisible() with toBeHidden() for hidden-state checks. |
dev/ag-grid-angular/src/tests/loading-overlay.playwright-spec.ts |
Replaces not.toBeVisible() with toBeHidden() for hidden-state checks. |
dev/ag-grid-angular/src/tests/infinite-selection.playwright-spec.ts |
Adds a targeted disable for playwright/no-wait-for-timeout. |
dev/ag-grid-angular/src/tests/external-filter-state.playwright-spec.ts |
Replaces not.toBeVisible() with toBeHidden() for hidden-state checks. |
dev/ag-grid-angular/src/tests/column-state.playwright-spec.ts |
Uses expect(bounds).not.toBeNull() and non-null assertions for bounding box usage; replaces a visibility negation with toBeHidden(). |
dev/ag-grid-angular/src/tests/column-menu.playwright-spec.ts |
Adds targeted disables for waitForTimeout and replaces not.toBeVisible() with toBeHidden() for hidden-state checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.