Skip to content

chore: added eslint-plugin-playwright#185

Merged
artembelik merged 1 commit into
mainfrom
chore/eslint-plugin-playwright
Jul 2, 2026
Merged

chore: added eslint-plugin-playwright#185
artembelik merged 1 commit into
mainfrom
chore/eslint-plugin-playwright

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

No description provided.

@artembelik artembelik self-assigned this Jul 2, 2026
Copilot AI review requested due to automatic review settings July 2, 2026 09:09
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit b4fe550):

https://data-grid-next--data-grid-pr-185-5cg8ijvw.web.app

(expires Tue, 07 Jul 2026 09:11:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b9d49913f5b5988e9af8690a8b37f16143707448

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces eslint-plugin-playwright to enforce Playwright testing best practices across the repo’s E2E test suite, and updates existing Playwright specs to comply with the newly enabled rules.

Changes:

  • Add eslint-plugin-playwright dependency (and lockfile entries).
  • Configure ESLint to apply plugin:playwright/recommended rules to Playwright spec files.
  • Update Playwright tests to satisfy Playwright ESLint recommendations (e.g., prefer locator() usage and toBeHidden()), plus add targeted rule disables for intentional waitForTimeout() usage.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Adds eslint-plugin-playwright to devDependencies.
yarn.lock Locks eslint-plugin-playwright and its dependency (globals).
.eslintrc.js Adds a Playwright-specific ESLint override extending plugin:playwright/recommended.
.eslintignore Ignores .angular and playwright-report directories.
dev/ag-grid-angular/src/tests/theme.playwright-spec.ts Updates interactions to use page.locator(...).hover()/click() patterns.
dev/ag-grid-angular/src/tests/quick-filter-state.playwright-spec.ts Replaces not.toBeVisible() with toBeHidden() for hidden-state checks.
dev/ag-grid-angular/src/tests/loading-overlay.playwright-spec.ts Replaces not.toBeVisible() with toBeHidden() for hidden-state checks.
dev/ag-grid-angular/src/tests/infinite-selection.playwright-spec.ts Adds a targeted disable for playwright/no-wait-for-timeout.
dev/ag-grid-angular/src/tests/external-filter-state.playwright-spec.ts Replaces not.toBeVisible() with toBeHidden() for hidden-state checks.
dev/ag-grid-angular/src/tests/column-state.playwright-spec.ts Uses expect(bounds).not.toBeNull() and non-null assertions for bounding box usage; replaces a visibility negation with toBeHidden().
dev/ag-grid-angular/src/tests/column-menu.playwright-spec.ts Adds targeted disables for waitForTimeout and replaces not.toBeVisible() with toBeHidden() for hidden-state checks.

Comment thread .eslintrc.js
@artembelik artembelik merged commit 9b17b8c into main Jul 2, 2026
9 checks passed
@artembelik artembelik deleted the chore/eslint-plugin-playwright branch July 2, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants