chore: sync playwright docker image version from package.json (#DS-5167)#189
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 4152fa3): https://data-grid-next--data-grid-pr-189-xinkmqbc.web.app (expires Wed, 08 Jul 2026 07:12:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to keep the Playwright Docker image version automatically aligned with the Playwright test runner version used in the repo, reducing manual drift between package.json and tools/e2e/Dockerfile.
Changes:
- Introduces a Node runner script (
tools/e2e/run.cjs) to run Docker Compose E2E with an injected Playwright version. - Updates the E2E Dockerfile / Compose setup to accept
PLAYWRIGHT_VERSIONas a build arg and use it in the base image tag. - Switches
package.jsonE2E Docker scripts to use the new runner and removes Dependabot Docker updates for the E2E Docker context.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/e2e/run.cjs | New wrapper that runs Docker Compose E2E while injecting PLAYWRIGHT_VERSION. |
| tools/e2e/Dockerfile | Uses ARG PLAYWRIGHT_VERSION to parameterize the Playwright base image tag. |
| tools/e2e/docker-compose.yml | Passes PLAYWRIGHT_VERSION through as a Docker build arg. |
| package.json | Replaces direct docker-compose commands with node tools/e2e/run.cjs scripts. |
| .github/dependabot.yml | Removes Docker ecosystem updates for /tools/e2e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.