feat(TagList): support Shift range selection (DS-5148)#410
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 94952e9): https://react-koobiq-next--prs-410-0fefbm07.web.app (expires Sun, 12 Jul 2026 08:45:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
Adds Shift-based range selection support to TagList by introducing shared range-selection utilities in @koobiq/react-primitives, wiring them into keyboard and pointer interactions, and updating consumer-facing docs/tests in @koobiq/react-components.
Changes:
- Implemented key-range computation and range selection application utilities for TagList state.
- Added a dedicated
useTagListRangeSelectionbehavior and integrated it into TagList keyboard handling. - Updated TagList item press handling, component tests, and MDX documentation to cover Shift+Arrow and Shift+Click selection.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/primitives/src/utils/tagListSelection.ts | New helpers to compute a contiguous key range and apply it to multi-selection state. |
| packages/primitives/src/utils/index.ts | Re-export TagList selection helpers from the primitives utils barrel. |
| packages/primitives/src/behaviors/useTagListRangeSelection.ts | New behavior hook to handle Shift+keyboard navigation range selection. |
| packages/primitives/src/behaviors/useTagListItem.ts | Adds Shift+Click range selection logic for individual tag items. |
| packages/primitives/src/behaviors/useTagList.ts | Integrates the new range-selection hook into TagList keyboard handling and blur cleanup. |
| packages/components/src/components/TagList/TagList.test.tsx | Updates/extends tests to validate new Shift range selection behaviors. |
| packages/components/src/components/TagList/TagList.mdx | Updates documentation to describe Shift-based selection and keyboard shortcuts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rmnturov
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.