fix(SelectNext): reset search-input on dropdown close (DS-5217)#414
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 37b1000): https://react-koobiq-next--prs-414-0l3ncmz5.web.app (expires Sat, 11 Jul 2026 10:11:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
This PR fixes SelectNext search behavior by clearing the internal search query when the dropdown closes (while preserving controlled inputValue behavior), aligning the component’s UX with DS-5217.
Changes:
- Add internal controlled state for the search query and reset it on open→close transitions for uncontrolled usage.
- Wire
SelectListsearch input changes through the new internal state setter to ensureonInputChangeis called consistently. - Add/extend Vitest coverage to validate reset behavior, default input handling, and controlled input preservation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/src/components/SelectNext/Select.tsx | Introduces controlled search input state + effect to reset query when the dropdown closes (uncontrolled only). |
| packages/components/src/components/SelectNext/tests/Select.test.tsx | Adds regression tests covering query reset on close, defaultInputValue behavior, and controlled inputValue not being reset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.