Skip to content

feat(SelectNext): add isReadOnly support (DS-5220)#415

Open
KamilEmeleev wants to merge 2 commits into
mainfrom
feat/ds-5220
Open

feat(SelectNext): add isReadOnly support (DS-5220)#415
KamilEmeleev wants to merge 2 commits into
mainfrom
feat/ds-5220

Conversation

@KamilEmeleev

Copy link
Copy Markdown
Collaborator

No description provided.

@KamilEmeleev KamilEmeleev added the enhancement New feature or request label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 85dbf6b):

https://react-koobiq-next--prs-415-yd52sqcl.web.app

(expires Sun, 12 Jul 2026 07:56:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds isReadOnly support to SelectNext so the control remains focusable but user interactions cannot change selection or open the dropdown, aligning behavior with Form-level read-only state and updating docs/stories/tests accordingly.

Changes:

  • Introduce isReadOnly prop + renderValue state flag for SelectNext.
  • Prevent selection changes/opening when read-only (and expose data-readonly for styling).
  • Add Storybook example, MDX docs section, and test coverage for read-only behavior (single + multiple).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/components/src/components/SelectNext/types.ts Adds isReadOnly prop and exposes it in renderValue state.
packages/components/src/components/SelectNext/Select.tsx Implements read-only behavior (blocks open/toggle and selection updates), adds data-readonly and styling hook.
packages/components/src/components/SelectNext/Select.stories.tsx Updates updated-date tag, adjusts Disabled story, adds ReadOnly story.
packages/components/src/components/SelectNext/Select.module.css Styles chevron for read-only state via data-readonly.
packages/components/src/components/SelectNext/Select.mdx Documents the new read-only behavior and embeds the new story.
packages/components/src/components/SelectNext/tests/SelectMultiple.test.tsx Adds multi-select read-only tests and adjusts tag rendering test props usage.
packages/components/src/components/SelectNext/tests/Select.test.tsx Adds read-only test suite and updates disabled clear button expectations.
packages/components/src/components/SelectedTags/SelectedTagsResponsive.tsx Makes tag remove actions render but disables them when read-only.
packages/components/src/components/SelectedTags/SelectedTagsMultiline.tsx Makes tag remove actions render but disables them when read-only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/src/components/SelectNext/Select.tsx
Comment thread packages/components/src/components/SelectNext/Select.tsx
Comment thread packages/components/src/components/SelectNext/Select.tsx
@KamilEmeleev KamilEmeleev requested a review from rmnturov July 9, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants