feat(SelectNext): add isReadOnly support (DS-5220)#415
Open
KamilEmeleev wants to merge 2 commits into
Open
Conversation
|
Visit the preview URL for this PR (updated for commit 85dbf6b): https://react-koobiq-next--prs-415-yd52sqcl.web.app (expires Sun, 12 Jul 2026 07:56:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
Adds isReadOnly support to SelectNext so the control remains focusable but user interactions cannot change selection or open the dropdown, aligning behavior with Form-level read-only state and updating docs/stories/tests accordingly.
Changes:
- Introduce
isReadOnlyprop +renderValuestate flag forSelectNext. - Prevent selection changes/opening when read-only (and expose
data-readonlyfor styling). - Add Storybook example, MDX docs section, and test coverage for read-only behavior (single + multiple).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/components/SelectNext/types.ts | Adds isReadOnly prop and exposes it in renderValue state. |
| packages/components/src/components/SelectNext/Select.tsx | Implements read-only behavior (blocks open/toggle and selection updates), adds data-readonly and styling hook. |
| packages/components/src/components/SelectNext/Select.stories.tsx | Updates updated-date tag, adjusts Disabled story, adds ReadOnly story. |
| packages/components/src/components/SelectNext/Select.module.css | Styles chevron for read-only state via data-readonly. |
| packages/components/src/components/SelectNext/Select.mdx | Documents the new read-only behavior and embeds the new story. |
| packages/components/src/components/SelectNext/tests/SelectMultiple.test.tsx | Adds multi-select read-only tests and adjusts tag rendering test props usage. |
| packages/components/src/components/SelectNext/tests/Select.test.tsx | Adds read-only test suite and updates disabled clear button expectations. |
| packages/components/src/components/SelectedTags/SelectedTagsResponsive.tsx | Makes tag remove actions render but disables them when read-only. |
| packages/components/src/components/SelectedTags/SelectedTagsMultiline.tsx | Makes tag remove actions render but disables them when read-only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.