Docker

[ryceg]

A straightforward docker setup, just so it can be deployed a little easier.

[kooshi]

Thanks for the effort! Unfortunately it looks like it doesn't work.

<AssemblyName>stserver</AssemblyName> in SseServer.csproj causes the output dll to be named stserver.dll.
I'd rather just remove the name override, so you can keep the command in the Docker file and just remove the AssemblyName property.

For some reason dotnet build was failing with --no-restore whenever I would try to update the container using docker-compose build --no-cache. I recommend just removing the explicit restore, and letting the build perform the restore itself, as that ended up working.

Also the docker-compose.yml and the Dockerfile have conflicting health check mechanisms. Ideally, it would be nice to actually test the health of the app by connecting to it, and wget or curl would be a minor addition. We should add a real /health endpoint in the server for that purpose as well. dotnet --version only tells us that the container is running, not if the app is healthy.

More importantly, it doesn't look like ASP.NET is picking up that ASPNETCORE_URLS variable, so it's not actually serving on the container's IP, only localhost still.

I don't use docker much, but for the sake of everyone else, I'd be happy to merge this once it's all tested and working!

If you don't mind, please add some instructions in the README about it once it's finalized as well.

[ryceg]

Yep, sorry- accidentally made the PR on yours instead of my own before I was able to test :')

[mario-dg]

Any updates on this?