feat(storage): foundation — integrity, manifest, profile, secrets, backend (PR1 of 4)#108
Open
sidd-27 wants to merge 2 commits into
Open
feat(storage): foundation — integrity, manifest, profile, secrets, backend (PR1 of 4)#108sidd-27 wants to merge 2 commits into
sidd-27 wants to merge 2 commits into
Conversation
Implements the pure-logic core of the bubbaloop storage subsystem from docs/superpowers/specs/2026-05-26-bubbaloop-storage-design.md (spec §17 "PR1"), with no Zenoh dependencies and full unit coverage: - integrity: streaming + one-shot SHA-256, hex/prefix8/base64 helpers, verify (mandatory per-chunk integrity, §11) - recording: manifest.json data model (§4.4) with forward-compatible unknown-field preservation and derived lifecycle/upload state - manifest: atomic write_tmp_then_rename save, load, structural validation (§3.4.5) - profile: profile YAML + full v1 validator (§4.3.1), reserved `pipelines:`->v2 gate (§4.3.2), canonical profile_sha256 (§4.3.3) - secrets: opaque zeroize-on-drop Secret (redacted Debug), secrets.toml chmod 0600 (§4.2) - backend: async StorageBackend trait + LocalFs impl with checksum verification and path-traversal guards; deterministic object-key builders (§8) S3Compat backend, discover/sync/reconcile/replay, CLI/MCP surfaces and the dashboard tab are deferred to later PRs per the spec phasing. Adds sha2, zeroize, async-trait deps. 57 unit tests; clippy-clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Enables building/testing on Apple Silicon (the workspace previously declared only linux-aarch64 and linux-64). No dependency changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This was referenced Jun 18, 2026
Contributor
Author
|
Stacked PR — review in order. Each merges into
Drafts #109–#111 currently show a cumulative diff against the spec branch; each collapses to its own phase automatically once the PR above it merges. |
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked split of #107 — part 1 of 4. The original PR bundled all four in-tree phases (~16.5k lines) into one branch, which isn't reviewable. This is the first of four sequential PRs, each scoped to one phase of the storage spec (
docs/superpowers/specs/2026-05-26-bubbaloop-storage-design.md, §17). PR2/3/4 open against this branch as each merges.PR1 — foundation (
crates/bubbaloop/src/storage/)The pure-logic core, no Zenoh/daemon dependencies, full unit coverage:
integrity— streaming + one-shot SHA-256, hex/prefix8/base64 helpers, verify (mandatory per-chunk integrity, §11).recording+manifest— themanifest.jsondata model (§4.4) with forward-compatible unknown-field preservation, derived lifecycle/upload state, atomicwrite_tmp_then_renamesave/load, and structural validation (§3.4.5).profile— profile YAML + full v1 validator (§4.3.1), reservedpipelines:→v2 gate (§4.3.2), canonicalprofile_sha256(§4.3.3).secrets— opaque zeroize-on-dropSecret(redactedDebug),secrets.tomlchmod 0600 (§4.2).backend— asyncStorageBackendtrait +LocalFsimpl with checksum verification, path-traversal guards, and deterministic object-key builders (§8).Also adds the
osx-arm64platform to the pixi workspace so it builds on Apple Silicon (no dependency changes). New deps:sha2,zeroize,async-trait.Scope boundary
S3-compatible backend, discover/sync/reconcile/replay, the CLI/MCP surfaces, and the dashboard are deferred to PR2–PR4 per the spec phasing.
Verification
57 unit tests; clippy-clean.
Review status
The original combined branch had a high-effort multi-agent code review with all findings fixed. The fixes are distributed across the PRs they touch.
🤖 Generated with Claude Code