Make configure usable with shells without 'which' and other improvements#32
Open
stepnem wants to merge 2 commits into
Open
Make configure usable with shells without 'which' and other improvements#32stepnem wants to merge 2 commits into
stepnem wants to merge 2 commits into
Conversation
POSIX does not require 'which' and some POSIX shells do not implement it (for example dash). The 'command' shell built-in is required by POSIX and is a better match for what CHECK_COMMAND tries to do, anyway. Also quote the function argument properly.
- remove unused variable 'config_default'
- fix whitespace handling (implicit "$@" instead of $*,
variable quoting)
- use 'printf' instead of 'echo' where the latter is fragile
or incorrect
- simplify ('false' instead of 'test 0 != 0', useless use of
sed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.