-
Notifications
You must be signed in to change notification settings - Fork 1
Include token in subgraph even if not covered by segmentation node #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomaskrause
merged 3 commits into
korpling:main
from
matthias-stemmler:fix-subgraph-for-uncovered-token
Apr 17, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if it was better to keep the error at part of the code and handle it in the calling function, thus falling back to the covered token borders in any case when there is an error. The method name could otherwise be a little bit misleading because one could expect it to only work when the segmentation coverage is given.
Since
get_left_right_token_with_offset_with_segmentationis only part of the internal API ofsubgraph.rsand not (crate) public this probably does not make a lot of a difference where the fallback is implemented.Also, the fallback at this position makes sense, since the
segmentationparameter is only used to extend the context to the left and right, not to reduce the already existing context given by the covered token by throwing an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had similar thoughts when deciding where to put the fallback, and concluded on the reasoning you're giving in your last paragraph. The
with_segmentationin the method name could be understood as "extend the context according to the segmentation if there is segmentation coverage" (and otherwise don't extend it).Handling it at the call site by applying the fallback in case of any error can potentially obscure other, unrelated, errors, so I thought keeping it here is the safer option.