Update test_boost_json.cpp#282
Open
beached wants to merge 1 commit intokostya:masterfrom
beached:patch-3
Open
Conversation
This shows the Boost JSON in a better light and uses safer at( ) instead of operator[] that will insert if the member doesn't exist. At throws. It also uses a more idiomatic, for read only JSON, use of memory_resource similar to RapidJSON's pooled allocator.
Collaborator
|
If you want safer operations, I'd recommend to change |
Contributor
Author
|
At is also faster than operator[] when I was checking. It has a const overload too, so if the object is const it would still work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows the Boost JSON in a better light and uses safer at( ) instead of operator[] that will insert if the member doesn't exist. At throws. It also uses a more idiomatic, for read only JSON, use of memory_resource similar to RapidJSON's pooled allocator.