Skip to content

🎨 Palette: [UX improvement] Add ARIA label and title to detail panel close button#36

Open
kourdroid wants to merge 1 commit into
mainfrom
palette-a11y-detail-close-btn-11970411066758803102
Open

🎨 Palette: [UX improvement] Add ARIA label and title to detail panel close button#36
kourdroid wants to merge 1 commit into
mainfrom
palette-a11y-detail-close-btn-11970411066758803102

Conversation

@kourdroid

Copy link
Copy Markdown
Owner

💡 What
Added aria-label="Close detail panel" and title="Close detail panel" to the icon-only (✕) close button within the #detail-panel.

🎯 Why
The button only contained the '✕' symbol, meaning screen readers would read it as "times" or similar, which does not convey its function. The addition of title also creates a helpful tooltip for mouse users who hover over the icon.

📸 Before/After
Before: <button class="detail-close" onclick="closeDetailPanel()">✕</button>
After: <button class="detail-close" aria-label="Close detail panel" title="Close detail panel" onclick="closeDetailPanel()">✕</button>

♿ Accessibility

  • Fixes screen reader accessibility for an icon-only button by providing an explicit descriptive aria-label.
  • Avoids WCAG 2.5.3 (Label in Name) violation by describing the action rather than the symbol.

PR created automatically by Jules for task 11970411066758803102 started by @kourdroid

Adds aria-label and title to the '✕' close button in the unit detail panel for better screen reader support and mouse hover tooltips.

Co-authored-by: kourdroid <36898160+kourdroid@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant