🎨 Palette: Improve DocumentReviewForm UX and Accessibility#45
Conversation
- Add `isSubmitting` state and `Loader2` spinner to "Approve & Save" button for better interaction feedback. - Use `useId` to generate unique IDs for form fields. - Link `Label`s to `Input`s using `htmlFor` and `id` for better accessibility. - Use `aria-labelledby` for read-only fields to ensure label association. - Fix typescript types for `validation` and `update` to resolve lint errors. Co-authored-by: kourdroid <36898160+kourdroid@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
This PR improves the UX and accessibility of the
DocumentReviewFormcomponent.Changes:
htmlFor,id, andaria-labelledby. UseduseIdto ensure unique IDs.anytypes in validation logic.Verification:
pnpm build.pnpm exec eslint.PR created automatically by Jules for task 12895785653075802079 started by @kourdroid