🎨 Palette: Add loading state & fix a11y in Review Form#64
Conversation
- Add `isSubmitting` state to `DocumentReviewForm` to show loading spinner on "Approve & Save". - Use `useId` to associate Labels with Inputs for accessibility. - Add unit test for `DocumentReviewForm`. - Add `.Jules/palette.md` for UX journaling. Co-authored-by: kourdroid <36898160+kourdroid@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
💡 What: Added a loading spinner to the "Approve & Save" button in
DocumentReviewFormand improved accessibility by associating labels with inputs.🎯 Why: Users lacked visual feedback during the async approval process, and form inputs were not programmatically associated with their labels (WCAG violation).
📸 Verification: Validated with a Playwright script showing the loading state and passing unit tests.
♿ Accessibility: Fixed missing
htmlFor/idassociations and added visual feedback for async actions.PR created automatically by Jules for task 7946302757591066191 started by @kourdroid