🎨 Palette: Refine badge container patterns and semantic colors in director view#100
🎨 Palette: Refine badge container patterns and semantic colors in director view#100kourdroid wants to merge 1 commit into
Conversation
…ector view Co-authored-by: kourdroid <36898160+kourdroid@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What: Refactored
typeBadge,statusBadge, andreadOnlyBadgein the Director incidents view (app/(director)/incidents.tsx) to utilize distinct<View>containers for box-model styles, decoupling them from<Text>components.Why: Directly applying structural styles (padding, background) to
<Text>components causes inconsistent rendering on native platforms and violates the application's UI structure conventions. Additionally, the badges were using hardcoded and/or incorrect design system tokens.Before/After: Before, badges were standalone text nodes mapping to base
TYPOGRAPHY.label. Now, badges are wrapped in<View>elements.statusBadgeleveragesCOLORS.signalRedTint/COLORS.signalGreenTintfor its background, andreadOnlyBadgecorrectly usesCOLORS.background(Field Gray) to free upCOLORS.accentexclusively for active actions. All badges correctly implementTYPOGRAPHY.labelUppercase.Polish: This aligns the Director view's components with the established memory constraint for semantic badges across Admin views, establishing uniform spacing, structural consistency, semantic color tinting, and precise typographic hierarchy.
PR created automatically by Jules for task 13075412498218665148 started by @kourdroid