🕸️ Spider: [SEO improvement] Add semantic dialog roles to AnnouncementPopup#147
🕸️ Spider: [SEO improvement] Add semantic dialog roles to AnnouncementPopup#147kourdroid wants to merge 1 commit into
Conversation
Added `role="dialog"`, `aria-modal="true"`, and `aria-labelledby` to the `AnnouncementPopup` modal. Also added a matching `id` to the title `<h2>`. This ensures proper semantic structure and accessibility. Co-authored-by: kourdroid <36898160+kourdroid@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What: Added
role="dialog",aria-modal="true", andaria-labelledbyto theAnnouncementPopupmotion div, and added anid="announcement-title"to the modal's title<h2>tag.🎯 Why: Custom modal implementations require explicit ARIA roles to be correctly parsed as dialog windows by screen readers and accessibility trees. Without them, the semantic structure is flattened.
📊 Impact: Improves accessibility (a11y) and overall semantic code quality, helping machine crawlers understand that the content within is part of a distinct overlay dialog rather than flow content.
PR created automatically by Jules for task 11562272199255576214 started by @kourdroid