Open
Conversation
Member
|
(sorry for the lag) obviously, you've given a fair share of attention to this little space oddity, and thank you for that. what an excellent insight. kindly bear with us for an extra short while to address these issues. also, make sure to stay on the tip to see how the master evolved in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P.S. could x?:y be used here, with the condition inverted?
Same with assignment printing suppression here
I also found the use of
r=here weird, could that be anxmacro instead?I also think a different ternary indentation in eval would be clearer, but that's a lot more personal preference.