feat(storage): move DecodeCallback to storage package, add SetFeatureSupported#3
Closed
zachsmith1 wants to merge 1 commit into
Closed
feat(storage): move DecodeCallback to storage package, add SetFeatureSupported#3zachsmith1 wants to merge 1 commit into
zachsmith1 wants to merge 1 commit into
Conversation
- Move DecodeCallback from etcd3 to storage package so non-etcd backends (Spanner) can use it - Add deprecated aliases in etcd3 for backwards compatibility - Add SetFeatureSupported() on feature checker so non-etcd backends can declare native feature support (e.g. RequestWatchProgress) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Contributor
Author
|
Closing in favor of pinning directly against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks 32f5e90 off the `feat/per-cluster-allocators` branch so the relocation can land independently of the larger per-cluster-allocators work. The change is a pure prerequisite for KPEP-0001 (pluggable storage backends) — without it, non-etcd backends cannot honor the cacher-installed decode callback.
Two related changes in one commit:
Why now
KPEP-0001 lands a registry of pluggable storage backends in `kplane-dev/storage`, with Spanner as the first non-etcd consumer. Spanner's source already uses `storage.WithDecodeCallback`, but no merged fork commit exposes it at the `storage` package — Spanner doesn't build standalone today. Pulling this commit out of `feat/per-cluster-allocators` (which has unrelated changes still in flight) unblocks:
…all of which can pin against this branch via pseudo-version while we iterate, then move to `main` once this merges.
Files
Test plan
Original commit author/co-author preserved from the cherry-pick.