Skip to content

Display resources for .yml files#80

Merged
nephio-prow[bot] merged 4 commits into
kptdev:mainfrom
r-yabyab:display-yml
Aug 19, 2025
Merged

Display resources for .yml files#80
nephio-prow[bot] merged 4 commits into
kptdev:mainfrom
r-yabyab:display-yml

Conversation

@r-yabyab
Copy link
Copy Markdown

Fixes #355

Display resources from .yml files and add null check to allow comment blocks in yaml files-- Example in the first resource block in multus-daemonset-thick.yml from nephio-example-packages which previously caused a runtime error if you tried to view its resources.

@nephio-prow
Copy link
Copy Markdown

nephio-prow Bot commented Jul 11, 2025

Hi @r-yabyab. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 5, 2025

@efiacor
Copy link
Copy Markdown

efiacor commented Aug 19, 2025

/approve
/lgtm

@nephio-prow
Copy link
Copy Markdown

nephio-prow Bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, r-yabyab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow Bot added the approved label Aug 19, 2025
@nephio-prow nephio-prow Bot merged commit d94a7eb into kptdev:main Aug 19, 2025
10 checks passed
@r-yabyab r-yabyab deleted the display-yml branch August 20, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nephio UI does not display resources from yml file extension

2 participants