Skip to content

Backstage enhancements to fix issues caused by revision field type change in porch from string to int#81

Merged
nephio-prow[bot] merged 7 commits into
kptdev:mainfrom
varun-chandramouli:porch-ver-issue-work
Apr 28, 2026
Merged

Backstage enhancements to fix issues caused by revision field type change in porch from string to int#81
nephio-prow[bot] merged 7 commits into
kptdev:mainfrom
varun-chandramouli:porch-ver-issue-work

Conversation

@varun-chandramouli
Copy link
Copy Markdown

Porch was  updated to  use integers as revision . but the backstage code was expecting only string values for revision field. I have fixed it to accept both string and integers as values for the revision field.  I tested it and it seems to be working fine.  at least we are now able to see the deployed packages

@nephio-prow nephio-prow Bot requested review from efiacor and johnbelamaric April 27, 2026 13:21
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 27, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@nephio-prow
Copy link
Copy Markdown

nephio-prow Bot commented Apr 27, 2026

Hi @varun-chandramouli. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@efiacor
Copy link
Copy Markdown

efiacor commented Apr 27, 2026

/ok-to-test

@varun-chandramouli
Copy link
Copy Markdown
Author

/retest

@varun-chandramouli
Copy link
Copy Markdown
Author

/retest

@efiacor
Copy link
Copy Markdown

efiacor commented Apr 27, 2026

@varun-chandramouli
Copy link
Copy Markdown
Author

node-gyp needs a fix.

https://prow.nephio.io/log?container=test&id=2048813815100870656&job=presubmit-kbp-lint

Hi . I didn't do any changes in this file . and in the log it says info This module is OPTIONAL, you can safely ignore this error .
I think this can be ignored.

@sonarqubecloud
Copy link
Copy Markdown

@efiacor
Copy link
Copy Markdown

efiacor commented Apr 28, 2026

/approve
/lgtm

@nephio-prow
Copy link
Copy Markdown

nephio-prow Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, varun-chandramouli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow Bot added the approved label Apr 28, 2026
@nephio-prow nephio-prow Bot merged commit 7c2e4fc into kptdev:main Apr 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants