DO-NOT-MERGE - Debug kpt live apply PR#1005
Draft
aravindtga wants to merge 9 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves deployment and CI failure diagnostics for Porch by surfacing more Kubernetes apply status output and collecting additional logs/cluster state during e2e job failures.
Changes:
- Emit
kpt live applystatus events during deploy. - Add extra
kubectl logsand CR/pod-readiness dumps to the e2e CI debug bundle.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| make/deploy.mk | Adds apply-time status event output to help diagnose deployment issues. |
| .github/workflows/porch-e2e-ci-jobs.yaml | Expands failure-time debugging output (logs, CRs, readiness info). |
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
03fd6da to
152465e
Compare
Contributor
|
can we not just add the do-not-merge-work-in-progress label? or was that porch only? or do we still not have rights to add these? |
Contributor
Author
I don't have rights to add any labels in this repo. |
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
080cf10 to
391b398
Compare
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
391b398 to
8802037
Compare
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
2 times, most recently
from
4777bfc to
6b2ce9d
Compare
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
61bcf9b to
f3260e3
Compare
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
11135da to
aeb514e
Compare
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
aeb514e to
90f1ff4
Compare
Comment on lines
22
to
24
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:subresource:status | ||
| // +kubebuilder:resource:path=servicetemplates,singular=servicetemplate | ||
| type ServiceTemplate struct { |
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
90f1ff4 to
7299629
Compare
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
3ad1f4d to
5954a25
Compare
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
debug-kpt-live-apply-stuck-issue
branch
from
6721edf to
3feec54
Compare
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR is created to debug the kpt live apply issue