Add end to end tests for subpackage support on the Porch v1alpha1 API#1013
Open
liamfallon wants to merge 40 commits into
Open
Add end to end tests for subpackage support on the Porch v1alpha1 API#1013liamfallon wants to merge 40 commits into
liamfallon wants to merge 40 commits into
Conversation
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end coverage for v1alpha1 subpackage clone/upgrade behavior and introduces supporting implementation changes in the task handler and upgrade mutation to make subpackage operations work end-to-end.
Changes:
- Add new e2e scenarios covering subpackage clone/upgrade success and failure cases (including nested paths).
- Add subpackage-aware handling in the generic task handler (injecting/upgrading subpackage resources into the parent package).
- Add subpackage-aware filtering in the upgrade mutation and add unit tests for subpackage dir validation/helpers.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
test/e2e/api/rpkg_subpkg_test.go |
New e2e tests exercising subpackage clone/upgrade success and failure scenarios. |
pkg/task/upgrade.go |
Filters local resources to a subpackage subtree when SubpackageDir is set. |
pkg/task/upgrade_test.go |
Adds unit tests for upgrade behavior when SubpackageDir is present/missing. |
pkg/task/generictaskhandler.go |
Applies subpackage clone/upgrade tasks by merging subpackage resources into the parent revision. |
pkg/task/generictaskhandler_test.go |
Adds tests for subpackage task application and resource insertion/upgrade behavior. |
api/porch/v1alpha1/util.go |
Adds SubpackageDir validation and changes GetSubpackageDir signature/behavior. |
api/porch/v1alpha1/util_test.go |
Adds tests for SubpackageDir validation and GetSubpackageDir. |
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
9a73502 to
05106cf
Compare
Signed-off-by: liamfallon <liam.fallon@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add end to end tests for subpackage support on the Porch v1alpha1 API
Important
The CI on this PR will not pass until #1009 is merged
Description
Related Issue(s)
Type of Change
Checklist
AI Disclosure