Cherry-pick: Add package resource file sizes to PackageRevision interface (#954)

[JamesMcDermott]

Title

Cherry-pick to 1.5: Add package resource file sizes to PackageRevision interface (#954)

---

Description

• What changed:
• Why it’s needed:
• How it works:

---

Related Issue(s)

• Closes/Fixes #

---

Type of Change

• Cherry-pick
• Bug fix
• New feature
• Enhancement
• Refactor
• Documentation
• Tests
• Other: ________

---

Checklist

• Code follows project style guidelines
• Self-reviewed changes
• Tests added/updated
• Documentation added/updated
• All tests and gating checks pass

---

Testing Instructions (Optional)

---

Additional Notes (Optional)

• Known issues:
• Further improvements:
• Review notes:

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new ResourcesSizeBytes field to PackageRevisionStatus that exposes the total size of a package revision's resource files (currently computed only by the DB cache), along with supporting schema migrations, end-to-end test helpers, and assorted comment/typo cleanups.

Changes:

• Adds resources_size column to the package_revisions table (schema + migration scripts) and threads a new resourcesSizeBytes field through dbPackageRevision so the API surfaces it in PackageRevisionStatus.
• Introduces TestSuite.UsingDBCache (driven by the DB_CACHE env var) and a shared validatePackageResourcesSize helper used across e2e tests; also adds tests for placeholder/main package revision edit/upgrade rejection.
• Cleans up assorted typos, comments, and copyright headers in API, docs, and engine code.

Reviewed changes

Copilot reviewed 25 out of 27 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
api/porch/types.go	Adds ResourcesSizeBytes to status; fixes comment typos.
api/porch/v1alpha1/types.go	Mirrors above for v1alpha1.
api/sql/porch-db.sql	Adds resources_size column to base schema.
api/sql/porch-db-1.5.9-1.5.10.sql	New forward migration adding/backfilling resources_size.
api/sql/porch-db-1.5.10-1.5.9.sql	New rollback migration dropping resources_size.
api/sql/porch-db-1.5.9-1.6.0.sql	Duplicate forward migration for 1.6.0.
api/sql/porch-db-1.6.0-1.5.9.sql	Duplicate rollback for 1.6.0.
controllers/.../packagevariant_controller-with-workspacename_test.go	Copyright year bump.
deployments/porch/3-porch-postgres-bundle.yaml	Mirrors schema column addition for bundled deployment.
docs/.../package-revisions.md	Cleans up sample YAML/CLI output.
docs/.../db-cache.md	Documents draft close size summation.
docs/.../api-ref.md	Documents new resourcesSizeBytes field.
pkg/cache/dbcache/dbpackagerevision.go	Stores/propagates resourcesSizeBytes; minor fixes.
pkg/cache/dbcache/dbpackagerevisionsql.go	SQL read/insert/update statements include resources_size.
pkg/cache/dbcache/dbrepository.go	Recomputes size on ClosePackageRevisionDraft.
pkg/cache/dbcache/dbreposync.go	Computes size during external PR sync.
pkg/engine/engine.go	Comment fixes.
pkg/externalrepo/git/doc.go	Comment typo fix.
pkg/task/generictaskhandler.go	Error message typo fix.
test/e2e/api/*.go	New validatePackageResourcesSize helper and additional placeholder edit/upgrade tests.
test/e2e/suiteutils/suite.go	Adds UsingDBCache and repoControllerInCluster fields.

Files not reviewed (1)

• api/porch/v1alpha1/zz_generated.conversion.go: Language not supported

[Copilot]

Pull request overview

Copilot reviewed 26 out of 28 changed files in this pull request and generated 10 comments.

Files not reviewed (1)

• api/porch/v1alpha1/zz_generated.conversion.go: Language not supported