Merged
Conversation
Previously, directories were considered covered if any parent CODEOWNERS rule matched them. This made it easy to miss adding explicit entries for new subdirectories when a broad parent rule already existed. The default match mode is now "exact", requiring each directory to have its own CODEOWNERS rule. Users can opt out per-directory with `match: coverage` to restore the previous behavior. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Parent CODEOWNERS rules (e.g.,
/apps/) silently satisfy coverage checks for subdirectories (e.g.,apps/autotune/services/autotune/), making it easy to forget adding explicit entries for new directories.What
exact— each configured directory must have its own CODEOWNERS rule, not just inherit from a parentmatch: coverageopt-out restores previous behavior per-directory