Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds incremental-correctness test coverage on top of the Iceberg branch, focused on failure/restart safety and duplicate-watermark paging behavior.
What’s Included
watermark + tiebreaker) does not skip rows when many records share the same watermark value.watermarksschema (withoutcursor_value) is migrated on open and existing progress is preserved.incremental_column_is_unique: trueworks without tiebreaker and persists progress.Files Changed
src/reader.rssrc/state.rssrc/sync.rsNew/Updated Tests
read_batch_cursor_paging_handles_duplicate_watermarksopen_migrates_legacy_watermarks_tablesync_table_resumes_from_saved_progresssync_table_fails_when_cursor_state_missing_in_cursor_modesync_table_supports_unique_watermark_without_tiebreakerValidation
cargo fmt --allcargo clippy --all-targets -- -D warningscargo test(all passing)Notes
RUSTREAM_IT_DB_URLand no-op when not set.