Make It Work on Windows#2
Conversation
Use `tmpfile` for cache files. No need to specify directory. Use PhpSpreadsheet to format benchmark output.
|
You mentioned this project in a discussion in PhpSpreadsheet, and you and I discussed it briefly there. Time to move the discussion here. My major problem with what you are doing is that it doesn't work on Windows. The With this change, the constructor for SpreadsheetSmartCache no longer needs a I admit that I do not know much about caching, and have, in consequence, not been able to come up with usable documentation for PhpSpreadsheet users on how it might be used. Setting up Redis or Apcu for myself is just too difficult. Yours comes without their additional setup needs, so it is attractive to me for documentation purposes if we can get it working in Windows. I hope I didn't break anything; I rely on your unit tests and benchmark script to tell me whether it works, and both run successfully for me. |
We don't need to report microseconds - seconds is sufficient. Right-align numbers when that feature is available in PhpSpreadsheet [TextGrid](PHPOffice/PhpSpreadsheet#4735).
Use
tmpfilefor cache files. No need to specify directory.Use PhpSpreadsheet to format benchmark output.