Cleanup and packaging#1
Open
drdaeman wants to merge 13 commits into
Open
Conversation
- Added .gitignore file - Removed generated files (*.pyc and OrderlyJSON*.py) from source tree - Added (incomplete, not working yet) setup.py (using distutils) - jsonschema and antlr3 (and its jars) are removed from the source tree - Test/example files are moved to test/data. No unit tests yet, though.
This seems a bit wrong, but when installed in "development mode" using `setup.py develop` required files are not built from ANTLR grammar.
Compiler/runtime version compatibility should be checked, but presently I have no idea on how this could be possibly done in setup.py (Note "3.2" runtime at kroo/py-orderly-json was a hack - 3.1.3 marked as 3.2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I've tried to package the code, so it could be uploaded to PyPi. I'm quite newbie to proper Python packaging, but
pip install -eandsetup.py'sinstall,build,bdistandsdistcommands seem to work fine.The only thing I really don't know how to do is checking antlr3 compiler and runtime version compatibility, so building with 3.2+ (with 3.1.3 runtime) will produce broken code. Sorry.
Hope this could be useful.