Harden parsing, coverage, and plugin lifecycle#10
Draft
krotname wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
GWLP_WNDPROChooks withSetWindowSubclassand moved cleanup out ofDllMain./PROFILEand static instrumentation; empty0/0reports now fail instead of reporting 100%.Root causes and impact
Several parsers accepted malformed or ambiguous input, the old width allocator was proportional to cell width, and the raw window-proc chain could retain a callback into an unloaded DLL. The coverage command filtered by a source path even though the tool's file filter targets instrumented modules, so an empty report passed the threshold. The sync workflow also committed before validation and generated
v*tags that could trigger an unrelated failing production release.Validation
git diff --check.Static native coverage follows the Microsoft C++ coverage guidance.