Collect operator pod description in e2e tests#76
Open
shreyabiradar07 wants to merge 1 commit intokruize:mvp_demofrom
Open
Collect operator pod description in e2e tests#76shreyabiradar07 wants to merge 1 commit intokruize:mvp_demofrom
shreyabiradar07 wants to merge 1 commit intokruize:mvp_demofrom
Conversation
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Reviewer's GuideUpdates e2e controller tests to collect additional diagnostics for the Kruize operator by scoping log collection to the kruize-operator control-plane label and adding a new step to capture the operator pod description into an artifacts directory. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the
control-plane=kruize-operatorlabel selector into a shared constant so it can be reused consistently across commands and updated in a single place if the label changes. - The
kubectl describe podsoutput can become quite large; you might want to either scope it to a single pod (e.g., using-o name+xargs describe) or truncate/rotate the description file to avoid excessively large artifacts on long‑running/debug-heavy runs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the `control-plane=kruize-operator` label selector into a shared constant so it can be reused consistently across commands and updated in a single place if the label changes.
- The `kubectl describe pods` output can become quite large; you might want to either scope it to a single pod (e.g., using `-o name` + `xargs describe`) or truncate/rotate the description file to avoid excessively large artifacts on long‑running/debug-heavy runs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR collects Kruize operator pod description in e2e tests along with pod logs.
Summary by Sourcery
Tests: