Skip to content

Collect operator pod description in e2e tests#76

Open
shreyabiradar07 wants to merge 1 commit intokruize:mvp_demofrom
shreyabiradar07:capture_operator_pod_events
Open

Collect operator pod description in e2e tests#76
shreyabiradar07 wants to merge 1 commit intokruize:mvp_demofrom
shreyabiradar07:capture_operator_pod_events

Conversation

@shreyabiradar07
Copy link
Copy Markdown
Contributor

@shreyabiradar07 shreyabiradar07 commented Mar 17, 2026

This PR collects Kruize operator pod description in e2e tests along with pod logs.

Summary by Sourcery

Tests:

  • Update e2e log collection to target Kruize operator pods explicitly and store their descriptions alongside existing pod logs.

Signed-off-by: Shreya Biradar <shbirada@ibm.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 17, 2026

Reviewer's Guide

Updates e2e controller tests to collect additional diagnostics for the Kruize operator by scoping log collection to the kruize-operator control-plane label and adding a new step to capture the operator pod description into an artifacts directory.

File-Level Changes

Change Details Files
Adjust operator log collection in e2e AfterAll hook and add operator pod description capture to test artifacts.
  • Continue to create a fresh /tmp/pod-logs directory with secure permissions before log collection
  • Change kubectl logs label selector from control-plane=controller-manager to control-plane=kruize-operator to correctly target the Kruize operator pods
  • After collecting operator logs, run kubectl describe pods with the same selector to capture the operator pod description
  • Write the operator pod description output to operator-pod-description.txt in the log directory with restrictive file permissions
test/e2e/e2e_test.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider extracting the control-plane=kruize-operator label selector into a shared constant so it can be reused consistently across commands and updated in a single place if the label changes.
  • The kubectl describe pods output can become quite large; you might want to either scope it to a single pod (e.g., using -o name + xargs describe) or truncate/rotate the description file to avoid excessively large artifacts on long‑running/debug-heavy runs.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the `control-plane=kruize-operator` label selector into a shared constant so it can be reused consistently across commands and updated in a single place if the label changes.
- The `kubectl describe pods` output can become quite large; you might want to either scope it to a single pod (e.g., using `-o name` + `xargs describe`) or truncate/rotate the description file to avoid excessively large artifacts on long‑running/debug-heavy runs.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Under Review

Development

Successfully merging this pull request may close these issues.

1 participant