Adding Github Workflow for ui [WIP]#227
Open
bhanvimenghani wants to merge 2 commits intokruize:mvp_demofrom
Open
Adding Github Workflow for ui [WIP]#227bhanvimenghani wants to merge 2 commits intokruize:mvp_demofrom
bhanvimenghani wants to merge 2 commits intokruize:mvp_demofrom
Conversation
|
Have you verified this in your local repo? |
Please take care of these warnings.
Update actions/setup-node@v3 -> actions/setup-node@v4
|
Contributor
Author
|
i have verified this in my local repo |
Yes, but the last stage failed. |
Contributor
Author
|
yes, unit tests needs to be re-done. |
bhanvimenghani
force-pushed
the
workflow
branch
from
66d8a91 to
36a6481
Compare
Hmm, I see. Can we hold this PR till all stages are successful? |
Contributor
Author
|
sure |
Can you add WIP/ convert it to a draft till resolve of all stages? |
bhanvimenghani
changed the title
bhanvimenghani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a github workflow which would be triggered while creating a pr or pushing to the main & mvp_demo branch.
Workflow deploys kruize, builds ui and runs test once proper testing is setup.