Skip to content

btrfs: restore mount option info messages during mount / btrfs: Align log messages and fix duplicates for NODATACOW/NODATASUM#4

Open
ksawaray wants to merge 2 commits into
masterfrom
fix-output-log2
Open

btrfs: restore mount option info messages during mount / btrfs: Align log messages and fix duplicates for NODATACOW/NODATASUM#4
ksawaray wants to merge 2 commits into
masterfrom
fix-output-log2

Conversation

@ksawaray

@ksawaray ksawaray commented Aug 12, 2025

Copy link
Copy Markdown
Owner
btrfs: restore mount option info messages during mount

    After the fsconfig migration, mount option info messages are no longer
    displayed during mount operations because btrfs_emit_options() is only
    called during remount, not during initial mount.

    Fix this by calling btrfs_emit_options() in btrfs_fill_super() after
    open_ctree() succeeds. Additionally, prevent log duplication by ensuring
    btrfs_check_options() handles validation with warn-level and err-level
    messages, while btrfs_emit_options() provides info-level messages.

    Fixes: eddb1a433f26 ("btrfs: add reconfigure callback for fs_context")
btrfs: Align log messages and fix duplicates for
    NODATACOW/NODATASUM

    Fix duplicate log messages and make them the same as the log output
    messages related to NODATACOW and NODATASUM, which are output with the
    same logic.

    Fixes: eddb1a433f26 ("btrfs: add reconfigure callback for fs_context")

After the fsconfig migration, mount option info messages are no longer
displayed during mount operations because btrfs_emit_options() is only
called during remount, not during initial mount.

Fix this by calling btrfs_emit_options() in btrfs_fill_super() after
open_ctree() succeeds. Additionally, prevent log duplication by ensuring
btrfs_check_options() handles validation with warn-level and err-level
messages, while btrfs_emit_options() provides info-level messages.

Fixes: eddb1a4 ("btrfs: add reconfigure callback for fs_context")
NODATACOW/NODATASUM

Fix duplicate log messages and make them the same as the log output
messages related to NODATACOW and NODATASUM, which are output with the
same logic.

Fixes: eddb1a4 ("btrfs: add reconfigure callback for fs_context")
@ksawaray ksawaray changed the title btrfs: restore mount option info messages during mount btrfs: restore mount option info messages during mount / btrfs: Align log messages and fix duplicates for NODATACOW/NODATASUM Aug 12, 2025
@ksawaray

Copy link
Copy Markdown
Owner Author

0000-cover-letter.patch

Subject: [PATCH v2 0/2] Fix and unify mount option log messages
To: clm@fb.com,
    josef@toxicpanda.com,
    dsterba@suse.com,
    johannes.thumshirn@wdc.com,
    brauner@kernel.org
Cc: linux-btrfs@vger.kernel.org

This patch series fixes and unifies the log messages related to btrfs
mount options.

The first patch addresses a regression where mount option messages were
no longer displayed during initial mounts after the fsconfig migration.

The second patch unifies the log messages for NODATACOW and NODATASUM
options, which were being handled with the same logic but had
inconsistent and duplicate messages.

Thanks,
Kyoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant