Updated serial_is_port_open() as suggested, plus previous additions#9
Open
eriksiers wants to merge 4 commits intokstenerud:masterfrom
Open
Updated serial_is_port_open() as suggested, plus previous additions#9eriksiers wants to merge 4 commits intokstenerud:masterfrom
eriksiers wants to merge 4 commits intokstenerud:masterfrom
Conversation
Author
|
I just realized that the diff shows changes to the entire file, but the actual changes (this time) are just to serial_is_port_open(). Sorry, I'm not very great with github. |
Owner
|
Huh that's strange... I wonder why git is doing that? Oh actually it might be the line endings. see. https://stackoverflow.com/questions/19593909/git-diff-sees-whole-file-as-changed-when-its-not So you should be able to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the changes made in my previous (closed) pull request, and incorporates suggested changes made to serial_is_port_open() -- except instead of using 'true', 'false', etc., I just return the value of the 'open' member of the serial_struct (so effectively an explicit 0 or 1).