Dexcom credential UX improvements and JSON injection fix#154
Open
miqcie wants to merge 1 commit intoktomy:mainfrom
Open
Dexcom credential UX improvements and JSON injection fix#154miqcie wants to merge 1 commit intoktomy:mainfrom
miqcie wants to merge 1 commit intoktomy:mainfrom
Conversation
UX: Add autocomplete attributes (username/current-password) and placeholder hints to Dexcom login fields so password managers can autofill. Add helper text clarifying these are the same credentials used in the Dexcom mobile app. Security: Add jsonStringEscape() helper and apply it to string values in the /api/status JSON response built by concatenation, preventing potential injection via crafted status strings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #143 (closed per request for focused PRs). Two changes: Dexcom credential UX improvements and a small security hardening fix.
Dexcom credential UX (data/index.html)
JSON injection hardening (src/ServerManager.cpp)
No captive portal, weather face, zip geocoding, or deferred restart included.
Builds clean: pio run -e ulanzi (71% flash, 17.6% RAM).