Skip to content

Address audit follow-ups for #8, #9, #15 (with batch CRUD for ktsu merge)#39

Merged
matt-edmondson merged 2 commits into
mainfrom
claude/github-issues-paFBg
May 9, 2026
Merged

Address audit follow-ups for #8, #9, #15 (with batch CRUD for ktsu merge)#39
matt-edmondson merged 2 commits into
mainfrom
claude/github-issues-paFBg

Conversation

@matt-edmondson
Copy link
Copy Markdown
Contributor

@matt-edmondson matt-edmondson commented May 9, 2026

Follow-up to the audits posted on #8, #9, #15. The decisions made there were:

Note: an earlier draft of this description said #36 closes #2. It doesn't — #2 was already closed on 2026-05-03 by removing the dead --batch flag. #36 re-adds the flag with real semantics.

What's in this PR

Test plan

  • ktools --help still lists merge correctly.
  • ktools merge batch save / list / show / delete round-trip through ISettingsService.
  • ktools merge --batch <name> runs a saved batch.
  • Mutual-exclusion: positional args + --batch errors with a clear message.
  • Existing ktools merge <dir> <file> invocation unchanged.

https://claude.ai/code/session_015z5JX7CrrvNdfjWDZNV3Hy

Documents the deliberate split between cross-repo orchestration (this
tool) and per-repo release automation (KtsuBuild) so users know where
to look. Per the recommendation on #9.
Adds a MergeBatchService backed by AppData persistence so users can
save named bundles of merge inputs and re-run them with `--batch`.
New top-level branch `merge-batch` exposes save/list/show/delete; the
existing `merge <dir> <file>` shape is unchanged.

Per the audit on #15 (sub-task A). Note the issue spec called for
`merge batch <verb>`; Spectre.Console.Cli doesn't easily support a
default command on a branch alongside subcommands, so this lands as a
sibling top-level branch `merge-batch` instead. CLI shape can be
revisited later without breaking storage.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@matt-edmondson matt-edmondson merged commit d067d2b into main May 9, 2026
5 checks passed
@matt-edmondson matt-edmondson deleted the claude/github-issues-paFBg branch May 9, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge --batch <NAME> option is silently ignored

2 participants