Skip to content

[1.21.1-NEO] Fix crash without advanced AE#49

Merged
kuba6000 merged 1 commit into1.21.1from
fix-adv-ae
Apr 25, 2026
Merged

[1.21.1-NEO] Fix crash without advanced AE#49
kuba6000 merged 1 commit into1.21.1from
fix-adv-ae

Conversation

@kuba6000
Copy link
Copy Markdown
Owner

Resolves #47

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the startup crash reported in issue #47 by ensuring mixins that reference AdvancedAE classes are only loaded/applied when the AdvancedAE mod is actually present.

Changes:

  • Removes AdvancedAE class references from the always-applied AE2 crafting CPU cluster mixin and retargets it to AE2’s CraftingCPUCluster.
  • Introduces a new AdvancedAE-only mixin (AdvCraftingCPUMixin) that implements ICraftingCPUCluster for AdvCraftingCPU.
  • Updates the mixin plugin to register the new AdvancedAE mixin only when advanced_ae is detected.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/advanced_ae/CraftingCPULogicMixin.java Minor class declaration tweak for the AdvancedAE crafting CPU logic mixin.
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/advanced_ae/AdvCraftingCPUMixin.java Adds an AdvancedAE-only implementation of ICraftingCPUCluster for AdvCraftingCPU.
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/MixinPlugin.java Registers the new AdvancedAE-only mixin when advanced_ae is present.
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/AE2/implementations/AECraftingCPUClusterMixin.java Removes the AdvancedAE branch and targets AE2 CraftingCPUCluster directly to prevent CNFE when AdvancedAE is missing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kuba6000 kuba6000 merged commit e20dedc into 1.21.1 Apr 25, 2026
6 checks passed
@kuba6000 kuba6000 deleted the fix-adv-ae branch April 25, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants