Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the startup crash reported in issue #47 by ensuring mixins that reference AdvancedAE classes are only loaded/applied when the AdvancedAE mod is actually present.
Changes:
- Removes
AdvancedAEclass references from the always-applied AE2 crafting CPU cluster mixin and retargets it to AE2’sCraftingCPUCluster. - Introduces a new AdvancedAE-only mixin (
AdvCraftingCPUMixin) that implementsICraftingCPUClusterforAdvCraftingCPU. - Updates the mixin plugin to register the new AdvancedAE mixin only when
advanced_aeis detected.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/advanced_ae/CraftingCPULogicMixin.java |
Minor class declaration tweak for the AdvancedAE crafting CPU logic mixin. |
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/advanced_ae/AdvCraftingCPUMixin.java |
Adds an AdvancedAE-only implementation of ICraftingCPUCluster for AdvCraftingCPU. |
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/MixinPlugin.java |
Registers the new AdvancedAE-only mixin when advanced_ae is present. |
src/main/java/pl/kuba6000/ae2webintegration/ae2interface/mixins/AE2/implementations/AECraftingCPUClusterMixin.java |
Removes the AdvancedAE branch and targets AE2 CraftingCPUCluster directly to prevent CNFE when AdvancedAE is missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kuba6000
added a commit
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #47