expose TLS mode per channel in metrics#2394
Open
fr-sarker wants to merge 2 commits into
Open
Conversation
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
There was a problem hiding this comment.
Pull request overview
Updates KubeDB installer assets to improve Neo4j TLS observability in the kubedb-metrics chart, and adjusts catalog image export/import helper artifacts.
Changes:
- Extend Neo4j metrics to expose TLS enablement and per-channel TLS/mTLS mode gauges.
- Remove several DB-version-specific
*-restic-pluginimage entries from catalog imagelists and the corresponding export/import/copy scripts.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kubedb-metrics/templates/neo4j/kubedb-com-neo4j.yaml | Adds TLS enabled + per-channel TLS mode metrics for Neo4j. |
| catalog/scripts/operator/import-into-k3s.sh | Drops import steps for several restic-plugin image tars in operator bundle workflow. |
| catalog/scripts/operator/import-images.sh | Drops push steps for several restic-plugin image tars in operator bundle workflow. |
| catalog/scripts/operator/imagelist.yaml | Removes several restic-plugin images from operator imagelist. |
| catalog/scripts/operator/export-images.sh | Drops pulls for several restic-plugin images in operator bundle workflow. |
| catalog/scripts/operator/copy-images.sh | Drops registry copy steps for several restic-plugin images in operator bundle workflow. |
| catalog/import-into-k3s.sh | Drops import steps for several restic-plugin image tars in full catalog workflow. |
| catalog/import-images.sh | Drops push steps for several restic-plugin image tars in full catalog workflow. |
| catalog/imagelist.yaml | Removes several restic-plugin images from the full catalog imagelist. |
| catalog/export-images.sh | Drops pulls for several restic-plugin images in full catalog workflow. |
| catalog/copy-images.sh | Drops registry copy steps for several restic-plugin images in full catalog workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
371
to
376
| - ghcr.io/kubedb/mariadb-coordinator:v0.46.0 | ||
| - ghcr.io/kubedb/mariadb-csi-snapshotter-plugin:v0.26.0 | ||
| - ghcr.io/kubedb/mariadb-init:0.9.0 | ||
| - ghcr.io/kubedb/mariadb-restic-plugin:v0.24.0_10.11.6-jammy | ||
| - ghcr.io/kubedb/mariadb-restic-plugin:v0.24.0_10.4.32-focal | ||
| - ghcr.io/kubedb/mariadb-restic-plugin:v0.24.0_10.6.16-focal | ||
| - ghcr.io/kubedb/mariadb-restic-plugin:v0.24.0_11.1.3-jammy | ||
| - ghcr.io/kubedb/mongodb-csi-snapshotter-plugin:v0.27.0 | ||
| - ghcr.io/kubedb/mongodb-init:4.2-v9 | ||
| - ghcr.io/kubedb/mongodb-init:6.0-v11 |
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.